Re: [PATCH net-next V1 00/10] Mellanox Ethernet driver updates 2013-01-30
From: David Miller <davem@davemloft.net>
Date: 2013-02-05 20:30:31
From: Ben Hutchings <redacted> Date: Tue, 5 Feb 2013 20:08:19 +0000
On Thu, 2013-01-31 at 13:51 -0500, David Miller wrote:quoted
From: Amir Vadai <redacted> Date: Thu, 31 Jan 2013 11:07:01 +0200quoted
Hi Dave, This series contains updates to mlx4 driver. Majority of the patches are small bug fixes. Another patch is to expose through debugfs some HW resources to be used by external tools. Patches done against net-next commit 1b13c97: "net/vxlan: Add ethtool drvinfo" Changes from V0: - Removed patch "net/mlx4_en: Add debugfs support". Need to find a standard way to do it, and no need to delay the other patches.All applied, thanks.The first time this series was posted (this is actually v2) I raised an issue with the changes to interpretation of the VLAN tag in ethtool RX NFC commands: <http://article.gmane.org/gmane.linux.network/257392/>. The semantics are now definitely inconsistent between sfc and mlx4_en. I asked Alexander what ixgbe (first implementation) does with the upper 4 bits, with the aim that all three implementations should be consistent, but I haven't had an answer to that yet.
I was hoping you guys would resolve this and post follow-on fixes if necessary.