Re: [PATCH 2/2] drivers: net:ethernet: cpsw: add support for VLAN
From: Richard Cochran <richardcochran@gmail.com>
Date: 2013-01-29 07:36:26
Also in:
linux-arm-kernel, linux-omap
On Tue, Jan 29, 2013 at 01:42:25AM +0530, Mugunthan V N wrote:
quoted hunk ↗ jump to hunk
@@ -947,6 +1042,10 @@ static const struct net_device_ops cpsw_netdev_ops = { #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = cpsw_ndo_poll_controller, #endif +#ifdef VLAN_SUPPORT + .ndo_vlan_rx_add_vid = cpsw_ndo_vlan_rx_add_vid, + .ndo_vlan_rx_kill_vid = cpsw_ndo_vlan_rx_kill_vid, +#endif
These are not compile time conditionals in net_device_ops, so I wonder (after reading Felipe's comments) whether you can simply keep the VLAN code always present. As long as the driver still compiles and loads, when VLAN is missing from the stack, then I don't see why you can't just leave it in, without all the ifdefs. Thanks, Richard