Re: [PATCH v3 1/1 net-next] net: fec: add napi support to improve proformance

2013/1/26 Francois Romieu [off-list ref]:

Waskiewicz Jr, Peter P [off-list ref] :
[...]

quoted

Also, when you're disabling interrupts above, you're doing that in your
HW interrupt handler, you should be using spin_lock_irqsave()/irq_restore().

Does the platform forbid to defer FEC_EIR / FEC_IEVENT write to the napi

I can clean FEC_IEVENT, but rx irq still issue if new package
received. I tested, performance drop if just clean FEC_IEVENT

poll handler and only disable the irq through FEC_EIMR / FEC_IMASK in
fec_enet_interrupt so as to remove the spinlock ?

I can remove this spin lock in other way.  I will send new patch.

(Frank, please keep an empty line between variables declarations and
function body).

Okay.

--
Ueimor