Re: [PATCH v2 1/1 net-next] net: fec: enable pause frame to improve rx prefomance for 1G network

From: Frank Li <redacted>
Date: Thu, 17 Jan 2013 10:50:36 +0800

Any feedback about this patch?

Well it's full of stylistic problems.

quoted

+       /* enable pause frame*/
+       if ((fep->pause_flag & FEC_PAUSE_FLAG_ENABLE) ||
+               ((fep->pause_flag & FEC_PAUSE_FLAG_AUTONEG) &&
+                       fep->phy_dev && fep->phy_dev->pause)) {

This is mis-idented.

quoted

+
+               rcntl |= FEC_ENET_FCE;

That empty line before this assignment is spurious.

quoted

+       pause->rx_pause = pause->tx_pause;
+
+}

That empty line is unnecessary, remove it.

quoted

+       /* default enable pause frame auto negotiation */
+       if (pdev->id_entry &&
+                       (pdev->id_entry->driver_data & FEC_QUIRK_HAS_GBIT))

You can't possibly tell me that this indentation looks right
to you.

You must style things like this:

	if (condition1 &&
	    condition2)

That is, you must line up the first character on the second and
subsequent lines at the first column after the openning parenthesis of
the first line.