Re: [PATCH v5 07/45] CPU hotplug: Provide APIs to prevent CPU offline from atomic context
From: Namhyung Kim <namhyung@kernel.org>
Date: 2013-01-29 10:21:27
Also in:
linux-arch, linux-arm-kernel, linux-pm, linuxppc-dev, lkml
Possibly related (same subject, not in this thread)
- 2013-02-08 · Re: [PATCH v5 07/45] CPU hotplug: Provide APIs to prevent CPU offline from atomic context · Paul E. McKenney <hidden>
- 2013-01-22 · [PATCH v5 07/45] CPU hotplug: Provide APIs to prevent CPU offline from atomic context · Srivatsa S. Bhat <hidden>
Hi Srivatsa, On Tue, 22 Jan 2013 13:04:54 +0530, Srivatsa S. Bhat wrote:
quoted hunk
@@ -246,15 +291,21 @@ struct take_cpu_down_param { static int __ref take_cpu_down(void *_param) { struct take_cpu_down_param *param = _param; - int err; + unsigned long flags; + int err = 0;
It seems no need to set 'err' to 0. Thanks, Namhyung
+ + percpu_write_lock_irqsave(&hotplug_pcpu_rwlock, &flags); /* Ensure this CPU doesn't handle any more interrupts. */ err = __cpu_disable(); if (err < 0) - return err; + goto out; cpu_notify(CPU_DYING | param->mod, param->hcpu); - return 0; + +out: + percpu_write_unlock_irqrestore(&hotplug_pcpu_rwlock, &flags); + return err; } /* Requires cpu_add_remove_lock to be held */ -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html