Re: [V2] xen-netback notify DomU to send ARP.

于 2013年01月21日 20:23, Ian Campbell 写道:

Which Linux did you test? pvops or something based on the classic-Xen
patches?

On Mon, 2013-01-21 at 11:55 +0000, Jan Beulich wrote:

quoted

quoted

quoted

quoted

On 21.01.13 at 08:26, jianhai luan [off-list ref] wrote:

+static void notify_front_arping(struct xenbus_device *dev)
+{
+	int err;
+
+	if (dev->state != XenbusStateConnected)
+		return;
+
+	err = xenbus_printf(XBT_NIL, dev->nodename, "state", "%d", dev->state);
+	if (err) {
+		pr_fmt("Error writing the state");

What's this? pr_fmt() alone makes no sense at all, and I'd be
pretty surprised if the compiler didn't warn about this construct.

Further, you probably want to say "re-writing" and include the
error code in the message. And of course you want a \n at the
end.

Finally - no need for the braces ...

quoted

+	}
+
+	return;

... nor this "return".

Agreed on all counts.

Jason, when you resend with these fixes please CC the netdev list and
folks listed by ./scripts/get-maintainers.pl for the patch.

Ian.

Thank you for your notifying.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Thanks,
Jason