Re: [patch] bnx2x: NULL dereference on error in debug code

From: "Ariel Elior" <redacted>
Date: Tue, 8 Jan 2013 14:50:50 +0000

quoted

-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-
owner@vger.kernel.org] On Behalf Of Dan Carpenter
Sent: Tuesday, January 08, 2013 3:42 PM
To: Eilon Greenstein
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
janitors@vger.kernel.org
Subject: [patch] bnx2x: NULL dereference on error in debug code

"vfop" is NULL here.  I've changed the debugging to not use it.

Signed-off-by: Dan Carpenter <redacted>
---
Only needed in linux-next.

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c

b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
index 71fcef0..3eef972 100644

--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c

@@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp,
 		return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor,
 					     cmd->block);
 	}
-	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop. rc %d\n",
-	   vf->abs_vfid, vfop->rc);
+	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop.\n", vf->abs_vfid);
 	return -ENOMEM;
 }

Right you are. Ack.

This is not the correct way to ack a patch, this is:

Acked-by: Ariel Elior <redacted>