[patch] bnx2x: NULL dereference on error in debug code

Subsystems: broadcom bnx2x 10 gigabit ethernet driver, networking drivers, the rest

STALE4950d

6 messages, 3 authors, 2013-01-10 · open the first message on its own page

[patch] bnx2x: NULL dereference on error in debug code

From: Dan Carpenter <hidden>
Date: 2013-01-08 13:42:18 

"vfop" is NULL here.  I've changed the debugging to not use it.

Signed-off-by: Dan Carpenter <redacted>
---
Only needed in linux-next.

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
index 71fcef0..3eef972 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
@@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp,
 		return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor,
 					     cmd->block);
 	}
-	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop. rc %d\n",
-	   vf->abs_vfid, vfop->rc);
+	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop.\n", vf->abs_vfid);
 	return -ENOMEM;
 }

RE: [patch] bnx2x: NULL dereference on error in debug code

From: Ariel Elior <hidden>
Date: 2013-01-08 14:51:27

quoted hunk
-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-
owner@vger.kernel.org] On Behalf Of Dan Carpenter
Sent: Tuesday, January 08, 2013 3:42 PM
To: Eilon Greenstein
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
janitors@vger.kernel.org
Subject: [patch] bnx2x: NULL dereference on error in debug code

"vfop" is NULL here.  I've changed the debugging to not use it.

Signed-off-by: Dan Carpenter <redacted>
---
Only needed in linux-next.

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
index 71fcef0..3eef972 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
@@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp,
 		return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor,
 					     cmd->block);
 	}
-	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop. rc %d\n",
-	   vf->abs_vfid, vfop->rc);
+	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop.\n", vf->abs_vfid);
 	return -ENOMEM;
 }
Right you are. Ack.
Thanks Dan,
Ariel

Re: [patch] bnx2x: NULL dereference on error in debug code

From: David Miller <davem@davemloft.net>
Date: 2013-01-08 22:31:00 

From: "Ariel Elior" <redacted>
Date: Tue, 8 Jan 2013 14:50:50 +0000
quoted
-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-
owner@vger.kernel.org] On Behalf Of Dan Carpenter
Sent: Tuesday, January 08, 2013 3:42 PM
To: Eilon Greenstein
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
janitors@vger.kernel.org
Subject: [patch] bnx2x: NULL dereference on error in debug code

"vfop" is NULL here.  I've changed the debugging to not use it.

Signed-off-by: Dan Carpenter <redacted>
---
Only needed in linux-next.

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
index 71fcef0..3eef972 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
@@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp,
 		return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor,
 					     cmd->block);
 	}
-	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop. rc %d\n",
-	   vf->abs_vfid, vfop->rc);
+	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop.\n", vf->abs_vfid);
 	return -ENOMEM;
 }
Right you are. Ack.
This is not the correct way to ack a patch, this is:

Acked-by: Ariel Elior <redacted>

RE: [patch] bnx2x: NULL dereference on error in debug code

From: Ariel Elior <hidden>
Date: 2013-01-08 14:54:17

quoted hunk
-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-
owner@vger.kernel.org] On Behalf Of Dan Carpenter
Sent: Tuesday, January 08, 2013 3:42 PM
To: Eilon Greenstein
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
janitors@vger.kernel.org
Subject: [patch] bnx2x: NULL dereference on error in debug code

"vfop" is NULL here.  I've changed the debugging to not use it.

Signed-off-by: Dan Carpenter <redacted>
---
Only needed in linux-next.

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
index 71fcef0..3eef972 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
@@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp,
 		return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor,
 					     cmd->block);
 	}
-	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop. rc %d\n",
-	   vf->abs_vfid, vfop->rc);
+	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop.\n", vf->abs_vfid);
 	return -ENOMEM;
 }

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
And now acking it properly.
Acked-by Ariel Elior [off-list ref]

RE: [patch] bnx2x: NULL dereference on error in debug code

From: Ariel Elior <hidden>
Date: 2013-01-09 07:39:21

quoted hunk
-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-
owner@vger.kernel.org] On Behalf Of Dan Carpenter
Sent: Tuesday, January 08, 2013 3:42 PM
To: Eilon Greenstein
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
janitors@vger.kernel.org
Subject: [patch] bnx2x: NULL dereference on error in debug code

"vfop" is NULL here.  I've changed the debugging to not use it.

Signed-off-by: Dan Carpenter <redacted>
---
Only needed in linux-next.

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
index 71fcef0..3eef972 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
@@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp,
 		return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor,
 					     cmd->block);
 	}
-	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop. rc %d\n",
-	   vf->abs_vfid, vfop->rc);
+	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop.\n", vf->abs_vfid);
 	return -ENOMEM;
 }

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Acked-by: Ariel Elior <redacted>

Re: [patch] bnx2x: NULL dereference on error in debug code

From: David Miller <davem@davemloft.net>
Date: 2013-01-10 07:53:52 

From: Dan Carpenter <redacted>
Date: Tue, 8 Jan 2013 16:42:14 +0300

"vfop" is NULL here.  I've changed the debugging to not use it.

Signed-off-by: Dan Carpenter <redacted>
Applied, thanks Dan.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help