Re: [PATCH v2 0/3] l2tp: fix ancillary data handling in ipv6 recv
From: David Miller <davem@davemloft.net>
Date: 2013-01-31 01:32:23
From: David Miller <davem@davemloft.net>
Date: 2013-01-31 01:32:23
From: Tom Parkin <redacted> Date: Wed, 30 Jan 2013 14:21:23 +0000
Patch 0001 includes some minor whitespace change in order to comply with checkpatch.pl's style recommendations.
Those whitspace recommendations do not match what we use in the networking. A function call shall be indented like so: ret = func(arg1, arg2, arg3, arg4, arg5, arg6); That is, the arguments on the second and subsequent lines shall be indented to the first column after the openning parenthesis of the first line. You must use whatever combination of TAB and space characters are necessary to achieve it. If you are indenting only using TAB characters, it is guarenteed that you are doing it wrong. You also need to reindent the arguments in function declarations in the header files that you modified. The function name is longer on the first line, therefore the openning parenthesis appears deeper in the line, and therefore the second and further lines of the declaration have to be indent adjusted. Thanks.