Re: [PATCH net-next 09/11] net/mlx4_en: Add debugfs support
From: David Miller <davem@davemloft.net>
Date: 2013-01-31 01:23:11
From: David Miller <davem@davemloft.net>
Date: 2013-01-31 01:23:11
From: Amir Vadai <redacted> Date: Wed, 30 Jan 2013 12:34:25 +0200
Add debugfs support to the mlx4_en driver such that users have the ability to access kernel information which can be used by external tools e.g HW monitoring ones The filesystem is set up in the following driver/interface hierarchy: <debugfs>
Sigh... This is a chronic problem. Every time some driver developer can't figure out a way, using existing well structured interfaces, to expose some information or statistic, they just throw their hands in the air and add some debugfs turd. Don't do this. Instead, use or extend existing, well structured and typed, interfaces to export your information. That way every driver can export similar information in a familiar way rather than with yet-another-debugfs-hack. I'm not applying this series, sorry.