Milos Vyletel [off-list ref] wrote:

----- Original Message -----

quoted

Milos Vyletel [off-list ref] wrote:

quoted

When bonding module is loaded with primary parameter and one decides
to unset
primary slave using sysfs these settings are not preserved during
bond device
restart. Primary slave is only unset once and it's not remembered in
bond->params structure.

Signed-off-by: Milos Vyletel <redacted>

	I think the patch is fine, although I did prefer the longer
commit message from the initial version (the one that explained how
to
reproduce the problem).

	-J

Signed-off-by: Jay Vosburgh <redacted>

Jay,

just to be sure, do you want me to resend this patch again with the
original commit message? It's no problem for me, I just don't want
to spam this list when not necessary.

	Yes.  Detailed commit messages are not spam.

	-J

Milos

quoted

quoted

---
drivers/net/bonding/bond_sysfs.c |    1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/bonding/bond_sysfs.c

b/drivers/net/bonding/bond_sysfs.c
index ef8d2a0..155f3b4 100644

--- a/drivers/net/bonding/bond_sysfs.c
+++ b/drivers/net/bonding/bond_sysfs.c

@@ -1067,6 +1067,7 @@ static ssize_t bonding_store_primary(struct

device *d,
		pr_info("%s: Setting primary slave to None.\n",
			bond->dev->name);
		bond->primary_slave = NULL;
+		memset(bond->params.primary, 0, sizeof(bond->params.primary));
		bond_select_active_slave(bond);
		goto out;
	}
--
1.7.1

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com