Thread (8 messages) 8 messages, 4 authors, 2013-01-29

Re: [PATCH] net: ks8851: convert to threaded IRQ

From: David Miller <davem@davemloft.net>
Date: 2013-01-29 03:31:59

From: Felipe Balbi <redacted>
Date: Wed, 23 Jan 2013 15:51:38 +0200
quoted hunk ↗ jump to hunk
@@ -1505,7 +1485,8 @@ static int ks8851_probe(struct spi_device *spi)
 	ks8851_read_selftest(ks);
 	ks8851_init_mac(ks);
 
-	ret = request_irq(spi->irq, ks8851_irq, IRQF_TRIGGER_LOW,
+	ret = request_threaded_irq(spi->irq, NULL, ks8851_irq,
+			IRQF_TRIGGER_LOW | IRQF_ONESHOT,
 			  ndev->name, ks);
You need to indent the second and third line of this function call
properly.  It should be:

	ret = function_call(arg1, arg2,
			    arg3, arg4,
			    arg5, arg6, etc.);

not what you have there now which has every line indented differently.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help