Re: [PATCH 2/2] v2 GRE: Add segmentation offload for GRE
From: Ben Hutchings <hidden>
Date: 2013-01-28 18:28:16
On Thu, 2013-01-24 at 14:16 -0800, Pravin B Shelar wrote:
Signed-off-by: Pravin B Shelar <redacted> --- Fixed according to comments from Jesse and Eric. - Factored a MAC layer handler out of skb_gso_segment(). - Eliminated copy operation from gre_gso_segment(). - Refresh header pointer after pskb_may_pull().
[...]
quoted hunk ↗ jump to hunk
--- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h@@ -307,6 +307,8 @@ enum { SKB_GSO_TCPV6 = 1 << 4, SKB_GSO_FCOE = 1 << 5, + + SKB_GSO_GRE = 1 << 6, }; #if BITS_PER_LONG > 32
[...] I think each new GSO flag must have a corresponding net device feature flag. In that case you'll need to replace NETIF_F_GSO_RESERVED1 in include/linux/netdev_features.h and add a name for the feature in net/core/ethtool.c. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.