Re: Potential problem in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process()
From: Larry Finger <hidden>
Date: 2013-01-27 22:11:51
Also in:
linux-wireless
From: Larry Finger <hidden>
Date: 2013-01-27 22:11:51
Also in:
linux-wireless
On 01/27/2013 03:18 PM, Guenter Roeck wrote:
Hi all,
while browsing through 'warning: variable ‘...’ set but not used' warnings, I
found the following code in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process().
while (!skb_queue_empty(&rx_queue)) {
_skb = skb_dequeue(&rx_queue);
_rtl_usb_rx_process_agg(hw, skb);
ieee80211_rx_irqsafe(hw, skb);
}
Question: Should the parameter to _rtl_usb_rx_process_agg() and
ieee80211_rx_irqsafe() be '_skb' instead of 'skb' ?I think you are right and I will submit a patch to fix this. What compiler version reported this? I use "gcc (SUSE Linux) 4.7.2 20130108 [gcc-4_7-branch revision 195012]" and I do not see this warning. Thanks, Larry -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html