Re: [PATCH v3] net, wireless: overwrite default_ethtool_ops

On Fri, Jan 11, 2013 at 3:59 PM, David Miller [off-list ref] wrote:

From: Ben Hutchings <redacted>
Date: Fri, 11 Jan 2013 20:00:32 +0000

quoted

On Fri, 2013-01-11 at 10:19 +0100, Stanislaw Gruszka wrote:

quoted

Since:

commit 2c60db037034d27f8c636403355d52872da92f81
Author: Eric Dumazet [off-list ref]
Date:   Sun Sep 16 09:17:26 2012 +0000

    net: provide a default dev->ethtool_ops

wireless core does not correctly assign ethtool_ops.

After alloc_netdev*() call, some cfg80211 drivers provide they own
ethtool_ops, but some do not. For them, wireless core provide generic
cfg80211_ethtool_ops, which is assigned in NETDEV_REGISTER notify call:

        if (!dev->ethtool_ops)
                dev->ethtool_ops = &cfg80211_ethtool_ops;

But after Eric's commit, dev->ethtool_ops is no longer NULL (on cfg80211
drivers without custom ethtool_ops), but points to &default_ethtool_ops.

In order to fix the problem, provide function which will overwrite
default_ethtool_ops and use it by wireless core.

Signed-off-by: Stanislaw Gruszka <redacted>

[...]

Acked-by: Ben Hutchings <redacted>

Applied.

Stanislaw, I see Eric's patch went in on v3.7-rc1 as such I suspect
this needs to be submitted as a stable fix for v3.7.5. Its already on
v3.8-rc4.

mcgrof@frijol ~/linux-stable (git::linux-3.7.y)$ git describe
--contains 2c60db037034d27f8c636403355d52872da92f81
v3.7-rc1~145^2~142

  Luis