Thread (24 messages) flat view 24 messages, 5 authors, 2013-01-21

Re: [RFC PATCH 1/3] ipv4: Invalidate the socket cached route on pmtu events if possible

From: Steffen Klassert <steffen.klassert@secunet.com>
Date: 2013-01-21 06:43:29

On Sat, Jan 19, 2013 at 02:54:04AM +0200, Julian Anastasov wrote:
quoted
+
+void ipv4_sk_update_pmtu(struct sk_buff *skb, struct sock *sk, u32 mtu)
+{
+	const struct iphdr *iph = (const struct iphdr *) skb->data;
+	struct flowi4 fl4;
+	struct rtable *rt = (struct rtable *) __sk_dst_get(sk);
	I guess __sk_dst_get should be called after
bh_lock_sock ?
Yes, absolutely. I'll fix it before I submit the patch.

Thanks for your review!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help