Re: [PATCH v2] net: fix wrong length of mac address

From: PJ Waskiewicz <redacted>
Date: Fri, 18 Jan 2013 00:30:32 -0800

On Fri, Jan 18, 2013 at 03:51:54PM +0800, Amos Kong wrote:

quoted

Typo, it should be ETH_ALEN.

Signed-off-by: Amos Kong <redacted>
---
v2: update commitlog, fix cc list
---
 drivers/net/hyperv/netvsc_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index f825a62..8264f0e 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c

@@ -349,7 +349,7 @@ static int netvsc_set_mac_addr(struct net_device *ndev, void *p)
 	struct net_device_context *ndevctx = netdev_priv(ndev);
 	struct hv_device *hdev =  ndevctx->device_ctx;
 	struct sockaddr *addr = p;
-	char save_adr[14];
+	char save_adr[ETH_ALEN];
 	unsigned char save_aatype;
 	int err;

While you're at it, you should also update drivers/net/hyperv/hyperv_net.h
to also fix the mac_adr definition in struct netvsc_device_info:

struct netvsc_device_info {

quoted

quoted

quoted

    unsigned char mac_adr[6];

Agreed.