Re: [PATCH for 3.8] iproute2: Add "ip netns pids" and "ip netns identify"

On Thu, 2013-01-17 at 16:23 -0800, Eric W. Biederman wrote:

Ben Hutchings [off-list ref] writes:

quoted

On Mon, 2012-11-26 at 17:16 -0600, Eric W. Biederman wrote:

[...]

quoted

quoted

--- a/ip/ipnetns.c
+++ b/ip/ipnetns.c

[...]

quoted

quoted

+static int is_pid(const char *str)
+{
+	int ch;
+	for (; (ch = *str); str++) {
+		if (!isdigit(ch))

ch must be cast to unsigned char before passing to isdigit().

isdigit is defined to take an int.  A legacy of the implicit casts in
the K&R C days.  Casting to unsigned char would be pointless and silly.

[...]

It's not pointless.  This is explained in the very first line of the
description in the manual page...

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.