Hello Eric

On 01/15/2013 07:05 PM, Eric Dumazet wrote:

On Tue, 2013-01-15 at 17:33 +0400, Alexey Perevalov wrote:

quoted

Hello

I would like to represent next version of patch I sent before
cgroup: "net_cls: traffic counter based on classification control cgroup"

The main idea is the same as was. It keeping counter in control groups, but now uses atomic instead of resource_counters.

Signed-off-by: Alexey Perevalov<redacted>
---
  include/net/cls_cgroup.h         |  200 ++++++++++++++++++++++++++++++++++----
  include/net/cls_counter_holder.h |   26 +++++
  init/Kconfig                     |   25 +++++
  kernel/cgroup.c                  |    2 +
  kernel/res_counter.c             |    4 +
  net/core/dev.c                   |    6 ++
  net/ipv4/tcp.c                   |   27 ++++-
  net/ipv4/udp.c                   |    6 ++
  net/sched/Kconfig                |   11 ---
  net/sched/Makefile               |    1 +
  net/sched/cls_cgroup.c           |  194 +++++++++++++++++++++++++++++++++++-
  net/sched/cls_counter_holder.c   |  144 +++++++++++++++++++++++++++
  12 files changed, 611 insertions(+), 35 deletions(-)
  create mode 100644 include/net/cls_counter_holder.h
  create mode 100644 net/sched/cls_counter_holder.c

Sorry, there are too many issues with this patch and I have not
a lot of time to review it.

0) No changelog or documentation

Do you expect documentation in Documentation/cgroups/.
For example I'll create new file net_cls.txt

1) There is no way you need to add kludges in tcp and udp for this
accounting. Retransmitted packets should not be ignored for example.

Retransmitted incoming packets will be ignored - right.
But counting on the 3rd layer of network stack (in netfilter) is 
expensive, we should twice resolve destination process.

2) Ugly #ifdef in c files. Don't do that please.

3) No check of kmalloc() returns (can be NULL)

This issues I'll fix.

-- 
Best regards,
Alexey Perevalov