Re: [net-next 09/15] e1000e: resolve checkpatch PREFER_PR_LEVEL warning
flat view
From: Joe Perches <joe@perches.com>
Date: 2013-01-11 17:03:38
On Fri, 2013-01-11 at 02:23 -0800, Jeff Kirsher wrote:
WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
[]
quoted hunk ↗ jump to hunk
@@ -4300,9 +4300,8 @@ static void e1000_print_link_info(struct e1000_adapter *adapter) u32 ctrl = er32(CTRL); /* Link status message must follow this format for user tools */ - printk(KERN_INFO "e1000e: %s NIC Link is Up %d Mbps %s Duplex, Flow Control: %s\n", - adapter->netdev->name, - adapter->link_speed, + pr_info("e1000e: %s NIC Link is Up %d Mbps %s Duplex, Flow Control: %s\n", + adapter->netdev->name, adapter->link_speed,
Don't these changes break a user-space tool? If not, please remove the comment above the pr_info()s and remove the unnecessary e1000e: prefixes.
quoted hunk ↗ jump to hunk
@@ -4521,8 +4520,8 @@ static void e1000_watchdog_task(struct work_struct *work)
[]
quoted hunk ↗ jump to hunk
/* Link status message must follow this format */ - printk(KERN_INFO "e1000e: %s NIC Link is Down\n", - adapter->netdev->name); + pr_info("e1000e: %s NIC Link is Down\n", + adapter->netdev->name);