Re: [PATCH] can: sja1000: fix compilation on x86
From: David Miller <davem@davemloft.net>
Date: 2012-12-14 21:38:00
Also in:
linux-can
From: Marc Kleine-Budde <mkl@pengutronix.de> Date: Fri, 14 Dec 2012 22:33:44 +0100
quoted hunk ↗ jump to hunk
@@ -121,7 +121,7 @@ static int sja1000_ofp_probe(struct platform_device *ofdev) } irq = irq_of_parse_and_map(np, 0); - if (irq == NO_IRQ) { + if (irq <= 0) { dev_err(&ofdev->dev, "no irq found\n"); err = -ENODEV; goto exit_unmap_mem;
I don't see anything existing which says this is the proper transformation. There is no consistency at all for the tests of the return value of irq_of_parse_and_map(). And if anything testing against zero is the correct thing to do, universally. I'm not applying this or pulling from your tree, sorry.