Re: [PATCH 4/4] FEC: Add time stamping code and a PTP hardware clock
From: Frank Li <hidden>
Date: 2012-12-18 08:51:35
Also in:
linux-arm-kernel
From: Frank Li <hidden>
Date: 2012-12-18 08:51:35
Also in:
linux-arm-kernel
quoted
might be an option, but given that this patch seems to have bypassed any review I feel more like reverting it.Instead of reverting, I suggest finding a solution (Frank) to let the code work when it can work and to prevent it when it cannot. This could be kconfig, DT, or run time probing of silicon revisions, but I don't have access to this hardware, and so I can't really say how to fix it.
I am traveling in this week. I will try to find out the solution after come back office in next week. But quick solution is shawn's patch, which resolve mx3 and mx5 problem at least in short term.
Just for the record, I did in fact review this patch, and I commented on exactly this point. Frank said we would address this point, and he did so. Not knowing the imx family very well, I took his word for it. After all, Frank has a Freescale address, and I would expect a Freescale employee to know how to provide the right fix. Thanks, Richard