Re: [PATCH 08/14] xen: netback: Remove redundant check on unsigned variable

On 11/16/2012 02:46 PM, Ian Campbell wrote:

On Fri, 2012-11-16 at 06:50 +0000, Tushar Behera wrote:

quoted

No need to check whether unsigned variable is less than 0.

CC: Ian Campbell <redacted>
CC: xen-devel@lists.xensource.com
CC: netdev@vger.kernel.org
Signed-off-by: Tushar Behera <redacted>

Acked-by: Ian Campbell <redacted>

Thanks.

This patch was not picked up for 3.8-rc1. Any idea, who should pick this up?

quoted

---
 drivers/net/xen-netback/netback.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index aab8677..515e10c 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c

@@ -190,14 +190,14 @@ static int get_page_ext(struct page *pg,
 
 	group = ext.e.group - 1;
 
-	if (group < 0 || group >= xen_netbk_group_nr)
+	if (group >= xen_netbk_group_nr)
 		return 0;
 
 	netbk = &xen_netbk[group];
 
 	idx = ext.e.idx;
 
-	if ((idx < 0) || (idx >= MAX_PENDING_REQS))
+	if (idx >= MAX_PENDING_REQS)
 		return 0;
 
 	if (netbk->mmap_pages[idx] != pg)

-- 
Tushar Behera