Thread (17 messages) flat view 17 messages, 3 authors, 2013-07-11

Re: [PATCH BUGFIX] pkt_sched: fix little service anomalies and possible crashes of qfq+

From: David Miller <davem@davemloft.net>
Date: 2012-12-26 23:13:59
Also in: lkml

From: Paolo valente <redacted>
Date: Wed, 19 Dec 2012 18:31:06 +0100
+	/*
+	 * The next assignment may let
+	 * agg->initial_budget > agg->budgetmax
+	 * hold, but this does not cause any harm
+	 */
Please format comments in the networking:

	/* Like
	 * this.
	 */

and

	/*
	 * Never
	 * like this.
	 */

I know this file is full of exceptions, but that error is to be
corrected rather than expanded.
+	/*
+	 * If lmax is lowered, through qfq_change_class, for a class
+	 * owning pending packets with larger size than the new value of lmax,
+	 * then the following condition may hold.
+	 */
Likewise.

And I'm not applying this until someone familiar with this code
does some review of this patch.  These are seriously non-trivial
changes.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help