Re: [PATCH] net: sched: integer overflow fix
From: Eric Dumazet <hidden>
Date: 2012-12-22 00:11:40
Also in:
lkml
Subsystem:
networking [general], tc subsystem, the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jamal Hadi Salim, Jiri Pirko, Linus Torvalds
On Fri, 2012-12-21 at 14:51 -0800, Eric Dumazet wrote:
On Fri, 2012-12-21 at 21:39 +0100, Stefan Hasko wrote:quoted
Fixed integer overflow in function htb_dequeue Signed-off-by: Stefan Hasko <redacted> --- net/sched/sch_htb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c index d2922c0..1bd3faa 100644 --- a/net/sched/sch_htb.c +++ b/net/sched/sch_htb.c@@ -919,7 +919,7 @@ ok: q->now = ktime_to_ns(ktime_get()); start_at = jiffies; - next_event = q->now + 5 * NSEC_PER_SEC; + next_event = q->now + (u32)5 * NSEC_PER_SEC; for (level = 0; level < TC_HTB_MAXDEPTH; level++) { /* common case optimization - skip event handler quickly */But this patch is wrong !
Please resend your patch using something like It will work much better.
diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c
index d2922c0..51561ea 100644
--- a/net/sched/sch_htb.c
+++ b/net/sched/sch_htb.c@@ -919,7 +919,7 @@ ok: q->now = ktime_to_ns(ktime_get()); start_at = jiffies; - next_event = q->now + 5 * NSEC_PER_SEC; + next_event = q->now + 5LLU * NSEC_PER_SEC; for (level = 0; level < TC_HTB_MAXDEPTH; level++) { /* common case optimization - skip event handler quickly */