Thread (2 messages) flat view 2 messages, 2 authors, 2012-12-03

Re: [PATCH] net: phy: smsc: force all capable mode if the phy is started in powerdown mode

From: David Miller <davem@davemloft.net>
Date: 2012-12-03 18:34:49
Also in: lkml

From: Philippe Reynes <redacted>
Date: Sat,  1 Dec 2012 21:44:49 +0100
 static int smsc_phy_config_init(struct phy_device *phydev)
 {
-	int rc = phy_read(phydev, MII_LAN83C185_CTRL_STATUS);
+	/*
+	 * If the SMSC PHY is in power down mode, then set it
+	 * in all capable mode before using it.
+	 */
+	int rc = phy_read(phydev, MII_LAN83C185_SPECIAL_MODES);
This is formatted poorly.  Do not put comments above the basic
block variable declarations, it looks terrible.

Also, comments in the networking code should be formatted:

	/* Like
	 * this.
	 */

	/*
	 * Not like
	 * this.
	 */

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help