Thread (3 messages) flat view 3 messages, 2 authors, 2012-12-04

Re: [PATCH] net/macb: Use dmapool to align descriptors on 64bits

From: Ben Hutchings <hidden>
Date: 2012-12-03 14:01:40
Also in: linux-arm-kernel, lkml

On Mon, 2012-12-03 at 13:15 +0100, Nicolas Ferre wrote:
Depending on datapath, some revisions of GEM need
64bits aligned descriptors. Use dmapool to allocate
these descriptors.
Note that different size between RX and TX rings
leads to the creation of two pools.

Signed-off-by: Nicolas Ferre <redacted>
[...]

dma_alloc_coherent() allocates whole pages, which I think is quite
enough alignment.  You can't save memory by doing this, since each pool
needs at least one page.  So what is this change meant to achieve?

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help