Re: [PATCH v2 net-next] team: add ethtool support
From: Ben Hutchings <hidden>
Date: 2012-12-31 22:16:33
On Sun, 2012-12-30 at 00:37 -0200, Flavio Leitner wrote:
quoted hunk ↗ jump to hunk
This patch adds few ethtool operations to team driver. Signed-off-by: Flavio Leitner <redacted> --- v2 - removed generic statistics from ethtool drivers/net/team/team.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index ad86660..7665a088 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c
[...]
+static void team_ethtool_get_drvinfo(struct net_device *dev,
+ struct ethtool_drvinfo *drvinfo)
+{
+ strncpy(drvinfo->driver, DRV_NAME, 32);
+ strncpy(drvinfo->version, UTS_RELEASE, 32);
+}[...] These must be null-terminated, so use strlcpy() not strncpy(). Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.