Re: [Patch v2] arp: fix a regression in arp_solicit()
From: David Miller <davem@davemloft.net>
Date: 2012-12-25 02:43:27
From: David Miller <davem@davemloft.net>
Date: 2012-12-25 02:43:27
From: Eric Dumazet <redacted> Date: Mon, 24 Dec 2012 08:41:14 -0800
On Mon, 2012-12-24 at 09:23 +0800, Cong Wang wrote:quoted
From: Cong Wang <redacted> Sedat reported the following commit caused a regression: commit 9650388b5c56578fdccc79c57a8c82fb92b8e7f1 Author: Eric Dumazet [off-list ref] Date: Fri Dec 21 07:32:10 2012 +0000 ipv4: arp: fix a lockdep splat in arp_solicit This is due to the 6th parameter of arp_send() needs to be NULL for the broadcast case, the above commit changed it to an all-zero array by mistake. Reported-by: Sedat Dilek <redacted> Tested-by: Sedat Dilek <redacted> Cc: Sedat Dilek <redacted> Cc: Eric Dumazet <edumazet@google.com> Cc: David S. Miller <davem@davemloft.net> Cc: Julian Anastasov <ja@ssi.bg> Signed-off-by: Cong Wang <redacted> ---Oops, thanks for fixing this. Acked-by: Eric Dumazet <edumazet@google.com>
Applied, thanks everyone.