Re: [B.A.T.M.A.N.] [PATCH 1/7] batman-adv: Move soft-interface initialization to ndo_init
From: Marek Lindner <hidden>
Date: 2012-12-24 19:37:57
Also in:
batman
From: Marek Lindner <hidden>
Date: 2012-12-24 19:37:57
Also in:
batman
On Monday, December 24, 2012 23:36:03 Pau Koning wrote:
On Mon, Dec 24, 2012 at 3:37 PM, Marek Lindner [off-list ref]
wrote:
quoted
On Monday, December 24, 2012 22:22:44 Pau Koning wrote:quoted
On Sat, Nov 24, 2012 at 1:02 AM, Sven Eckelmann [off-list ref]
wrote:
quoted
quoted
quoted
The initialization of an net_device object should be done in the init/constructor function and not from the outside after the register_netdevice was done to avoid race conditions.This patchset seems to be similar. Shouldn't it have been part of 3.8-rc1 or got rejected? Neither of it happened in the last monthIt was discussed and a decision was made. Please read all mails in this thread before making noise.What decision? I only see something about Patch 6 and Patch 7: Antonio Quartulli doesn't want rtnetlink support in batman-adv. I don't see any other statement about the rest of the patchset.
Quoting Antonio:
quoted
quoted
Anyway, I discussed about this together with the others and it seems that a proper solution now is to wait before merging this patchset and fix the current sysfs/rtnl_lock problem first. What do you think? Adding a new API without fixing the current one doesn't sound like a good move. <<< What isn't clear ? Cheers, Marek