Re: [PATCH V2 01/12] bridge: Add vlan filtering infrastructure
From: Eric Dumazet <hidden>
Date: 2012-12-18 21:13:54
From: Eric Dumazet <hidden>
Date: 2012-12-18 21:13:54
On Tue, 2012-12-18 at 14:00 -0500, Vlad Yasevich wrote:
+static void br_vlan_destroy(struct net_bridge_vlan *vlan)
+{
+ if (!bitmap_empty(vlan->port_bitmap, PORT_BITMAP_LEN)) {
+ pr_err("Attempt to delete a VLAN %d from the bridge with "
+ "non-empty port bitmap (%p)\n", vlan->vid, vlan);
+ BUG();
+ }
+
+ hlist_del_rcu(&vlan->hlist);
+ synchronize_net();
+ kfree_rcu(vlan, rcu);
+}Not clear why you both use synchronize_net() and kfree_rcu()