Thread (1 message) 1 message, 1 author, 2012-12-14

Re: [PATCHv2][RFC] smsc95xx: enable dynamic autosuspend

From: Ming Lei <hidden>
Date: 2012-12-14 16:24:37

On Fri, Dec 14, 2012 at 10:22 PM, Oliver Neukum [off-list ref] wrote:
On second thought, I think that if a driver can do manage_power(), even
only for a subset of devices, it should implement it. Doctoring the table of methods
is very, very ugly,
Sorry, why is it very ugly?  netdev_ops/ethtool_ops is still set dynamically
inside bind().
especially as this not protected by a lock.
Looks lock isn't needed since probe/remove and open/close path
can't be concurrent.


Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help