Re: [PATCH net-next 1/2] net: ethtool: Add destination MAC address to flow steering API

On 12/11/2012 11:55 AM, Or Gerlitz wrote:

On Tue, Dec 11, 2012 at 7:37 PM, Alexander Duyck
[off-list ref] wrote:

quoted

Is there any special reason why you need to change the size of this
structure?  It seems like you could probably just replace the data
section with a union containing either 8 bytes of user specified data or
your MAC address data.  Then we wouldn't need all of the changes to the
rest of the flow specifier.

basically, we followed Ben's suggestions made here
http://marc.info/?t=134977576500003

After looking over Ben's suggestion it makes sense.

Since I am pretty much responsible for the ixgbe implementation of this
I will do a few quick tests once the patches are applied to make certain
that there were no issues introduced on our end.

Thanks,

Alex