Re: [PATCH net-next v3 01/22] bnx2x: Support probing and removing of VF device
From: David Miller <davem@davemloft.net>
Date: 2012-12-10 18:35:22
From: "Ariel Elior" <redacted> Date: Mon, 10 Dec 2012 17:46:25 +0200
static void bnx2x_get_pcie_width_speed(struct bnx2x *bp, int *width, int *speed)
{
- u32 val = REG_RD(bp, PCICFG_OFFSET + PCICFG_LINK_CONTROL);
+ u32 val = 0;
+ pci_read_config_dword(bp->pdev, PCICFG_LINK_CONTROL, &val);Please put an empty line between function local variable declarations and actual code.
quoted hunk ↗ jump to hunk
@@ -12023,85 +12057,115 @@ static int bnx2x_get_num_non_def_sbs(struct pci_dev *pdev, * If MSI-X is not supported - return number of SBs needed to support * one fast path queue: one FP queue + SB for CNIC */ - if (!pos) + if (!pos) { + pr_info("no msix capability found"); return 1 + cnic_cnt; + } + + pr_info("msix capability found");
Use dev_info(), netdev_info(), or similar, rather than plain pr_info().