Thread (9 messages) flat view 9 messages, 4 authors, 2012-12-07

Re: [RFC PATCH] af_packet: don't to defrag shared skb

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2012-12-07 21:41:21
Also in: linux-wireless

On Fri, 2012-12-07 at 22:30 +0100, Johannes Berg wrote:
The only other theory I can come up with right now is that the skb_get()
happens in deliver_skb via __netif_receive_skb. Keeping in mind that
wpa_supplicant might have another packet socket open for authentication
packets, that seems like a possibility. I'll test it once I figure out
how to do this "defrag" option you speak of :)
Hmm now I'm venturing into the unknown (for me) and realm of
speculation...

wpa_supplicant opens a packet socket for ETH_P_EAPOL, which indirectly
eventually calls dev_add_pack(). But if you do the same for another
socket, you'll get the same again, and then deliver_skb() will deliver
only a refcounted packet to the prot_hook->func().

This seems like it could very well cause the problem?

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help