Re: [RFC] wireless: check against default_ethtool_ops

On Fri, 2012-12-07 at 13:16 +0100, Stanislaw Gruszka wrote:

Since:

commit 2c60db037034d27f8c636403355d52872da92f81
Author: Eric Dumazet [off-list ref]
Date:   Sun Sep 16 09:17:26 2012 +0000

    net: provide a default dev->ethtool_ops

wireless core does not correctly assign ethtool_ops. In order to fix
the problem, and avoid assigning ethtool_ops on each individual cfg80211
driver, we check against default_ethool_ops pointer instead of NULL in
wireless core.

Signed-off-by: Stanislaw Gruszka <redacted>

[...]
Acked-by: Ben Hutchings <redacted>

Ideally you could do this assignment unconditionally in the setup
function for the device, but it doesn't seem like there's a common
allocation path that you could do that in.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.