RE: [net-next 6/8] bna: Add Stats Clear Counter

From: Ben Hutchings [mailto:bhutchings@solarflare.com]
Sent: Thursday, December 06, 2012 12:55 PM

On Thu, 2012-12-06 at 12:34 -0800, Rasesh Mody wrote:

quoted

quoted

From: Ben Hutchings [mailto:bhutchings@solarflare.com]
Sent: Wednesday, December 05, 2012 6:20 PM
Subject: Re: [net-next 6/8] bna: Add Stats Clear Counter

On Wed, 2012-12-05 at 15:01 -0800, Rasesh Mody wrote:

quoted

Added Stats clear counter to the bfi_enet_stats_mac structure and
ethtool stats

Signed-off-by: Rasesh Mody <redacted>

Since this structure appears to be part of the firmware interface,
you should combine this (and any other interface changes) with the
change to the requested firmware version (7/8).

Ben,

Thanks for the feedback. Yes, bfi_enet_stats_mac is a part of firmware
interface update.

In future submission, I will plan to take care of combining such
firmware interface updates/changes and the firmware request version
change into single patch. Please let me know if you think it is
required for this patch set.

That's not my decision.

I have resubmitted the patch set to address you feedback.

Thanks,
Rasesh