Re: [PATCH net-next v2] bridge: export multicast database via netlink
From: Cong Wang <hidden>
Date: 2012-12-05 02:08:59
Also in:
bridge
On Tue, 2012-12-04 at 08:53 -0800, Stephen Hemminger wrote:
On Mon, 3 Dec 2012 21:03:43 +0800 Cong Wang [off-list ref] wrote:quoted
V2: drop patch 1/2, export ifindex directly Redesign netlink attributes Improve netlink seq check Handle IPv6 addr as well TODO: remove debugging printk's This patch exports bridge multicast database via netlink message type RTM_GETMDB. Similar to fdb, but currently bridge-specific. We may need to support modify multicast database too (RTM_{ADD,DEL}MDB). Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: Stephen Hemminger <redacted> Cc: "David S. Miller" <davem@davemloft.net> Cc: Thomas Graf <tgraf@suug.ch> Cc: Jesper Dangaard Brouer <redacted> Signed-off-by: Cong Wang <redacted>Minor nit reported by checkpatch was the messages should be using the api which provides the most info in the log to identify. WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... #190: FILE: net/bridge/br_mdb.c:28: + printk(KERN_INFO "no router on bridge\n") There is a set of macro's already for use in bridging code: br_info(br, "no router on bridge\n");
Never mind, removing these printk's is in my TODO list. :)