On Saturday 01 December 2012 11:44:34 Eric Dumazet wrote:
[...]

quoted

quoted

I have no idea of why you believe there is a problem here.

Could you explain how net_todo_list could be not empty ?

As long as no device is unregistered between
rtnl_trylock()/rtnl_unlock(), there is no possible deadlock.

I am not sure what "here" means for your. At least batman-adv tries to
unregister a device -> problem [1]. I will not make any judgements about
the other uses in the kernel/other parts patched by Simon.

I was reacting to the change in net/bridge/br_sysfs_br.c

Yes, in this context it makes more sense.

rtnl_trylock() could set a boolean flag to explicitly WARN_ON()
in case we try to unregister a device.

Sounds interesting.

Kind regards,
	Sven