Re: [PATCH net-next v1 3/3] net/mlx4_en: Set number of rx/tx channels using ethtool
From: David Miller <davem@davemloft.net>
Date: 2012-12-01 16:25:57
From: David Miller <davem@davemloft.net>
Date: 2012-12-01 16:25:57
From: Or Gerlitz <redacted> Date: Sat, 1 Dec 2012 17:50:09 +0200
On Sat, Dec 1, 2012 at 1:58 AM, Ben Hutchings [off-list ref] wrote:quoted
The values of max_tx and max_rx are passed in from userland, so you can't trust them.Is this a general statement re ethtool values passed from user space or something specific here? can't one assume that the ethtool process runs under the appropriate admin permission?
He's saying that you need to carefully validate the arguments, not that appropriate permissions haven't been checked.