Thread (89 messages) read the whole thread 89 messages, 6 authors, 2012-12-03

Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc

From: chas williams - CONTRACTOR <hidden>
Date: 2012-11-27 18:55:00
Also in: lkml

On Tue, 27 Nov 2012 18:02:29 +0000
David Woodhouse [off-list ref] wrote:
In solos-pci at least, the ops->close() function doesn't flush all
pending skbs for this vcc before returning. So can be a tasklet
somewhere which has loaded the address of the vcc->pop function from one
of them, and is going to call it in some unspecified amount of time.

Should we make the device's ->close function wait for all TX and RX skbs
for this vcc to complete? 
the driver's close routine should wait for any of the pending tx and rx
to complete.  take a look at the he.c in driver/atm
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help