Thread (9 messages) flat view 9 messages, 3 authors, 2012-11-20

Re: [PATCH] pkt_sched: QFQ Plus: fair-queueing service at DRR cost

From: David Miller <davem@davemloft.net>
Date: 2012-11-19 23:48:32
Also in: lkml

From: Paolo Valente <redacted>
Date: Mon, 12 Nov 2012 17:48:33 +0100
[This patch received positive feedback from Stephen Hemminger ("put in
net-next"), but no further feedback or decision. So I am (re)sending
an updated version of it. The only differences with respect to the
previous version are the support for TSO/GSO (taken from QFQ), and a
hopefully improved description.]
Can you rearrange the logic so that the compiler doesn't emit this
warning?

In file included from net/sched/sch_qfq.c:18:0:
net/sched/sch_qfq.c: In function ‘qfq_dequeue’:
include/net/sch_generic.h:480:15: warning: ‘skb’ may be used uninitialized in this function [-Wmaybe-uninitialized]
net/sched/sch_qfq.c:1007:18: note: ‘skb’ was declared here

You and I both know that SKB will be initialized at this point, but
the compiler can't see it clearly enough.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help