Thread (6 messages) 6 messages, 3 authors, 2012-11-03

Re: [PATCH 10/16] drivers/net/ethernet/ibm/emac/mal.c: use WARN

From: Julia Lawall <hidden>
Date: 2012-11-03 16:35:13
Also in: kernel-janitors, lkml

While looking i have noticed that a lot of drivers define there private "assert" macro.
It is very similar to warn.

(e.g.)
#define RTL819x_DEBUG
#ifdef RTL819x_DEBUG
#define assert(expr) \
       if (!(expr)) {                                  \
                printk( "Assertion failed! %s,%s,%s,line=%d\n", \
               #expr,__FILE__,__FUNCTION__,__LINE__);          \
       }
WARN is more complicated.  At least with the right debugging options 
turned on, it dumps the stack, via warn_slowpath_common.

julia
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help