Re: [PATCH v2 net-next] net: move inet_dport/inet_num in sock_common
From: David Miller <davem@davemloft.net>
Date: 2012-11-28 17:02:47
From: David Miller <davem@davemloft.net> Date: Wed, 28 Nov 2012 11:48:35 -0500 (EST)
I like this a lot, applied, thanks Eric!
And I'd like it even more if it was build tested :-/ net/ipv4/inet_hashtables.c: In function ‘__inet_lookup_established’: net/ipv4/inet_hashtables.c:242:7: error: expected expression before ‘)’ token net/ipv4/inet_hashtables.c:246:8: error: expected expression before ‘)’ token net/ipv4/inet_hashtables.c:267:7: error: expected expression before ‘)’ token net/ipv4/inet_hashtables.c:274:8: error: expected expression before ‘)’ token net/ipv4/inet_hashtables.c:226:2: warning: unused variable ‘acookie’ [-Wunused-variable] net/ipv4/inet_hashtables.c: In function ‘__inet_check_established’: net/ipv4/inet_hashtables.c:326:7: error: expected expression before ‘)’ token net/ipv4/inet_hashtables.c:341:7: error: expected expression before ‘)’ token net/ipv4/inet_hashtables.c:307:2: warning: unused variable ‘acookie’ [-Wunused-variable] net/ipv4/inet_hashtables.c:306:6: warning: unused variable ‘dif’ [-Wunused-variable] This is with gcc-4.7.2-2 on Fedora 17 on an allmodconfig build.