Re: [PATCH 2/2] smsc75xx: support PHY wakeup source

On Tue, 2012-11-27 at 14:28 +0000, Steve Glendinning wrote:

This patch enables LAN7500 family devices to wake from suspend
on either link up or link down events.

[]

[]

+static int smsc75xx_enter_suspend1(struct usbnet *dev)
+{
+	u32 val;
+	int ret;
+
+	ret = smsc75xx_read_reg_nopm(dev, PMT_CTL, &val);
+	check_warn_return(ret, "Error reading PMT_CTL");

Hi Steve, can you please add newlines to these new
check_warn_<foo> messages and the netdev_<level> ones too?
It helps avoid message interleaving.

+		if (!link_up) {
+			struct mii_if_info *mii = &dev->mii;
+			netdev_info(dev->net, "entering SUSPEND1 mode");

etc..