Re: private netdev flags into UAPI?

On 27/11/2012 04:03, David Howells wrote:

Or Gerlitz [off-list ref] wrote:

quoted

On Mon, Nov 26, 2012 at 11:22 AM, David Howells [off-list ref] wrote:

quoted

They were exposed to userspace already

So the script carries the bug into a new directory... why? AFAIK,
intentionally there's no way to read private flags from user space, so
what's the point in defining them there?

How should the script know what's private and what's not?  By the
encapsulation of code inside __KERNEL__ blocks.  In their absence, everything
is assumed to be public - given it is already part of the UAPI.  I don't know
that the code is private rather than the comment is wrong.

makes sense, but I have pointed on a bug in the final result, so this 
way or another, the fact that the bug
existed before doesn't mean we should carry it over.

Or.