Thread (9 messages) flat view 9 messages, 3 authors, 2012-11-26

Re: [PATCH] net: ipmr: limit MRT_TABLE identifiers

From: Chen Gang <hidden>
Date: 2012-11-26 02:29:08

于 2012年11月26日 10:19, Eric Dumazet 写道:
On Mon, 2012-11-26 at 09:34 +0800, Chen Gang wrote:
quoted
    if "pimre%u" (or another format), will not hurt the functional features, I suggest to use it
      since, we need try our best to not touch the OS API. 
      ("pimreg%u" seems an internal format, not OS API Level)
Have you taken a look at user code base before suggesting such a
change ?
  maybe a hacker can do ?  (I just guess).

  for my experience:
    It is necessary to think of more coding ways, when we have to give comments inside a function.

My patch is the safest change: Just make sure machine doesnt crash if
user ask stupid things.

No possible regression.




-- 
Chen Gang

Asianux Corporation
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help