Re: [PATCH 9/9] batman-adv: Use packing of 2 for all headers before an ethernet header

On Thursday 22 November 2012 08:12:38 Kevin Curtis wrote:

quoted

quoted

Agree. But we should get this message also to the other guys

What message would this be?
Are you advocating a different use of #pragma pack()?

David started this discussion and his statement was:

The __packed attribute is an abstraction of the actual syntax the 
compiler uses, if it is supported at all.

Therefore, you can't just unconditionally use the #pragma, and you 
would need to use some kind of similar compiler abstraction for it.

So yes, it sounds to me like "don't use #pragma but think about some 
abstraction".

Kind regards,
	Sven