RE: [PATCH] ixgbe: fix broken PPTP handling
From: Vick, Matthew <hidden>
Date: 2012-11-20 17:12:38
quoted hunk ↗ jump to hunk
-----Original Message----- From: netdev-owner@vger.kernel.org [mailto:netdev- owner@vger.kernel.org] On Behalf Of Alan Cox Sent: Tuesday, November 20, 2012 8:33 AM To: netdev@vger.kernel.org Subject: [PATCH] ixgbe: fix broken PPTP handling From: Alan Cox <redacted> Reported to the maintain 3 weeks ago so now sending a patch rather than waiting. ixgbe passes a random event type to the pptp code Signed-off-by: Alan Cox <redacted> --- drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.cb/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c index 01d99af..73291fe 100644--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c@@ -398,6 +398,7 @@ void ixgbe_ptp_check_pps_event(struct ixgbe_adapter*adapter, u32 eicr) switch (hw->mac.type) { case ixgbe_mac_X540: + event.type = PTP_CLOCK_PPS; ptp_clock_event(adapter->ptp_clock, &event); break; default:
CCing e1000-devel, the mailing list for Intel Wired Ethernet support. Sorry, Alan--I didn't see any message from you about this before or I would have responded. NAK on this, since I don't see how ixgbe is passing a random event type. The event type gets set to PTP_CLOCK_PPS just a few lines above (before the if (!adapter->ptp_clock) block). Matthew