Thread (44 messages) 44 messages, 7 authors, 2012-11-21

Re: [Xen-devel] [PATCH] xen/netfront: handle compound page fragments on transmit

flat view

From: Eric Dumazet <hidden>
Date: 2012-11-20 15:28:33

On Tue, 2012-11-20 at 15:06 +0000, Ian Campbell wrote:
In practice no because of the property that the number of pages backing
the frags is <= MAX_SKB_FRAGS even if you are using compound pages as
the frags.
Yes, but you can make this test trigger with some hacks from userland
(since the frag allocator is per task instead of per socket), so you
should remove the dump_stack() ?

Best way would be to count exact number of slots.

This could be something like 48 slots for a single skb

(if each frag is 4098 (1+4096+1)bytes, only the last one is around 4000
bytes)

MAX_SKB_FRAGS is really number of frags, while your driver needs a count
of 'order-0' 'frames'
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help